Horton

Re: explain plans with information about (modified) gucs

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: John Naylor <john.naylor@2ndquadrant.com>
Cc: Sergei Agalakov <sergei.agalakov@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-01-22T01:29:06Z
Lists: pgsql-hackers 

On 1/22/19 1:35 AM, John Naylor wrote:
> On Sun, Jan 20, 2019 at 2:31 PM Tomas Vondra
> <tomas.vondra@2ndquadrant.com> wrote:
>> Attached is v6 of the patch, adopting "settings" instead of "guc".
> 
> Ok, looks good. I tried changing config values with the .conf file,
> alter system, and alter database, and tried a few queries with
> auto_explain. I made a pass through the config parameters, and don't
> see anything obviously left out. I have no comments on the source
> code.
> 
> One thing stands out: For the docs on auto_explain, all other options
> have "Only superusers can change this setting.", but log_settings
> doesn't.

Yes, that's an omission in the docs. Will fix.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add SETTINGS option to EXPLAIN, to print modified settings.

  2. Switch some palloc/memset calls to palloc0