Re: test_fsync label adjustments
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-01-18T23:06:09Z
Lists: pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes: > Tom Lane wrote: >> Bruce Momjian <bruce@momjian.us> writes: >>> I have modified test_fsync to use test labels that match wal_sync_method >>> values, and and added more tests for open_sync with different sizes. >> Given that it was unclear whether the first such test was of any value, >> why are you slowing down the program by adding more? > Greg Smith indicated it has value, so I made it more complete. No? My recollection of that discussion is a bit different: there wasn't a clear-cut reason to rip it out. But the more tests you add to test_fsync, the less useful it becomes. regards, tom lane