Re: gen_guc_tables.pl: Validate required GUC fields before code generation

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Chao Li <li.evan.chao@gmail.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-25T16:00:34Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

gen_guc_tables.pl: Validate required GUC fields before code generation
- 7169c0b96bb8 19 (unreleased) landed

On 20.11.25 06:51, Chao Li wrote:
> 
> On Wed, Nov 19, 2025 at 7:56 PM Dagfinn Ilmari Mannsåker 
> <ilmari@ilmari.org <mailto:ilmari@ilmari.org>> wrote:
> 
> 
>      > v3 goes back to v1 plus I add a check for unknown field type per your
>      > suggestion, for example:
>      > ```
>      > error: guc_parameters.data line 2271: unknown GUC type 'intt'
>      > ```
> 
>     We've already validated that the name field exists, so this error
>     message should include that, like the other ones do.
> 
> 
> Make sense. I added field name to this error message in v4, now it looks 
> like:
> ```
> error: guc_parameters.dat line 2278: 'primary_conninfo' has unknown GUC 
> type 'string1'
> ```

Thanks, I committed this.  I made some changes to the error message 
format so that it matches the format recognized by editors, and to use 
PostgreSQL quoting style (double quotes).  I also removed some code 
comments that just restated what was already obvious from the code.