Horton

Re: pg_create_logical_replication_slot argument incongruency

Florin Irion <irionr@gmail.com>

View thread View on postgr.es
From: Florin Irion <irionr@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Date: 2022-09-20T06:41:56Z
Lists: pgsql-hackers

Attachments


On 20/09/22 03:33, Michael Paquier wrote:
> On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
>> This was introduced in commit 19890a06.
>>
>> IMHO we should use the documented argument name `two_phase` and change the
>> function to accept it.
>>
>> What do you think?
> 
> 19890a0 is included in REL_14_STABLE, and changing an argument name is
> not acceptable in a stable branch as it would imply a catversion
> bump.  Let's change the docs so as we document the parameter as
> "twophase", instead.
> --
> Michael

I understand. 

OK, patch only for the docs attached.

Cheers, 
Florin
www.enterprisedb.com

Commits

  1. doc: Fix parameter name for pg_create_logical_replication_slot()

  2. Add option to enable two_phase commits via pg_create_logical_replication_slot.