Horton

Re: Built-in CTYPE provider

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es
From: Jeff Davis <pgsql@j-davis.com>
To: Noah Misch <noah@leadboat.com>, Peter Eisentraut <peter@eisentraut.org>, Daniel Verite <daniel@manitou-mail.org>, Jeremy Schneider <schneider@ardentperf.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-07-18T06:06:43Z
Lists: pgsql-hackers 
On Wed, 2024-07-17 at 15:03 -0700, Noah Misch wrote:
> If I'm counting the votes right

...

> , you and Tom have voted that the feature's
> current state is okay, and I and Laurenz have voted that it's not
> okay.

...

> A tie would become a decision against the unreleased behavior.

...

> In the event of a decision against the unreleased behavior, reverting
> the
> feature is the remedy that could proceed without further decision
> making.

You haven't established that any problem actually exists in version 17,
and your arguments have been a moving target throughout this subthread.

I reject the procedural framework that you are trying to establish.
Voting won't change the fact that the "stability within a major
version" that you are arguing against[1] was highlighted as a benefit
in my initial proposal[2] for all reviewers to see.

If you press forward with this approach, I'll use judgement that is
sufficiently deferential to the review process before making any hasty
decisions.

Alternatively, I suggest that you participate in the thread that I
started here:

https://www.postgresql.org/message-id/d75d2d0d1d2bd45b2c332c47e3e0a67f0640b49c.camel%40j-davis.com

which seems like a more direct (and more complete) path to a resolution
of your concerns. I speak only for myself, but I assure you that I have
an open mind in that discussion, and that I have no intention force a
Unicode update past objections.

Regards,
	Jeff Davis

[1]
https://www.postgresql.org/message-id/20240711125040.11.nmisch@google.com
[2]
https://www.postgresql.org/message-id/ff4c2f2f9c8fc7ca27c1c24ae37ecaeaeaff6b53.camel@j-davis.com

Commits

  1. Support PG_UNICODE_FAST locale in the builtin collation provider.

  2. Support Unicode full case mapping and conversion.

  3. Fix test failures when language environment is not UTF-8.

  4. Add unicode_strtitle() for Unicode Default Case Conversion.

  5. Use version for builtin collations.

  6. Fix convert_case(), introduced in 5c40364dd6.

  7. Inline basic UTF-8 functions.

  8. Support C.UTF-8 locale in the new builtin collation provider.

  9. Fix another warning, introduced by 846311051e.

  10. Address more review comments on commit 2d819a08a1.

  11. Fix unreachable code warning from commit 2d819a08a1.

  12. Introduce "builtin" collation provider.

  13. Catalog changes preparing for builtin collation provider.

  14. Unicode case mapping tables and functions.

  15. Add Unicode property tables.

  16. Documentation update for Standard Collations.

  17. Cleanup for unicode-update build target and test.

  18. Shrink Unicode category table.

  19. Make some error strings more generic

  20. pg_upgrade: copy locale and encoding information to new cluster.

  21. Update Unicode data to Unicode 15.0.0

  22. Create a new type category for "internal use" types.