Re: PATCH: Configurable file mode mask
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Stephen Frost <sfrost@snowman.net>, Simon Riggs <simon@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>,
Adam Brightwell <adam.brightwell@crunchydata.com>
Date: 2017-03-06T14:06:15Z
Lists: pgsql-hackers
Attachments
- file-mode-mask-v2.patch (text/plain) patch v2
On 3/6/17 8:50 AM, Stephen Frost wrote: > * Simon Riggs (simon@2ndquadrant.com) wrote: >>> to allow the default mode of files and directories >>> in the $PGDATA directory to be modified. >> >> Are you saying if this is changed all files/directories will be >> changed to the new mode? > > No, new files will be created with the new mode and existing files will > be allowed to have the mode set. Changing all of the existing files > didn't seem like something we should be trying to do at server start. > >> It seems like it would be annoying to have some files in one mode, >> some in another. > > It's not intended for that to happen, but it is possible for it to. The > alternative is to try and forcibly change all files at server start time > to match what is configured but that didn't seem like a great idea. Agreed. It would definitely affect server start time, perhaps significantly. I have added a note to the docs that a change in file_mode_mask does not automatically change the mode of existing files on disk. This patch applies cleanly on 6f3a13f. -- -David david@pgmasters.net
Commits
-
Allow group access on PGDATA
- c37b3d08ca68 11.0 landed
-
Refactor dir/file permissions
- da9b580d8990 11.0 landed
-
Revert "Add basic TAP test setup for pg_upgrade"
- 58ffe141eb37 11.0 cited
-
Add basic TAP test setup for pg_upgrade
- f41e56c76e39 11.0 cited