Re: Add exclusive backup deprecation notes to documentation

Laurenz Albe <laurenz.albe@cybertec.at>

From: Laurenz Albe <laurenz.albe@cybertec.at>
To: David Steele <david@pgmasters.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-28T16:08:05Z
Lists: pgsql-hackers
David Steele wrote:
> This patch attempts to document the limitations of the exclusive mode.

Thanks!

> +   <para>
> +     The primary issue with the exclusive method is that the
> +     <filename>backup_label</filename> file is written into the data directory
> +     when <function>pg_start_backup</function> is called and remains until
> +     <function>pg_stop_backup</function> is called.  If
> +     <productname>PostgreSQL</productname> or the host terminates abnormally

There should be a comma at the end of this line.

> +     then <filename>backup_label</filename> will be left in the data directory
> +     and <productname>PostgreSQL</productname> will not start. A log message

You should say "*may* not start", because it will if the WAL segment is still there.

> +     recommends that <filename>backup_label</filename> be removed if not
> +     restoring from a backup.
> +   </para>

Yours,
Laurenz Albe



Commits

  1. Warn more strongly about the dangers of exclusive backup mode.