Re: Schema variables - new implementation for Postgres 15

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

To: Pavel Stehule <pavel.stehule@gmail.com>

Cc: Sergey Shinderuk <s.shinderuk@postgrespro.ru>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Julien Rouhaud <rjuju123@gmail.com>, dean.a.rasheed@gmail.com, er@xs4all.nl, joel@compiler.org, Dmitry Dolgov <9erthalion6@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2023-03-29T10:17:29Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow underscores in integer and numeric constants.
- faff8f8e47f1 16.0 cited
Remove special outfuncs/readfuncs handling of RangeVar.catalogname.
- 3cece34be842 16.0 cited
Remove extra space from dumped ALTER DEFAULT PRIVILEGES.
- 2af33369e794 16.0 cited
Create FKs properly when attaching table as partition
- b0284bfb1db5 16.0 cited
psql: improve tab-complete's handling of variant SQL names.
- 02b8048ba5dc 15.0 cited

On 24.03.23 08:04, Pavel Stehule wrote:
> Maybe I can divide the  patch 0002-session-variables to three sections - 
> related to memory management, planning and execution?

Personally, I find the existing split not helpful.  There is no value 
(to me) in putting code, documentation, and tests in three separate 
patches.  This is in fact counter-helpful (to me).  Things like the 
DISCARD command (0005) and the error messages changes (0009) can be 
separate patches, but most of the rest should probably be a single patch.

I know you have been asked earlier in the thread to provide smaller 
patches, so don't change it just for me, but this is my opinion.