Re: [19] CREATE SUBSCRIPTION ... SERVER

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Shlok Kyal <shlok.kyal.oss@gmail.com>

Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Joe Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org

Date: 2026-01-11T04:55:01Z

Lists: pgsql-hackers

Attachments

v16-0001-CREATE-SUBSCRIPTION-.-SERVER.patch (text/x-patch) patch v16-0001

On Fri, 2025-12-26 at 13:52 -0800, Jeff Davis wrote:
> On Wed, 2025-04-02 at 17:58 +0530, Shlok Kyal wrote:
> > I reviewed the patch and I have a comment:
> > 
> > If version is >=18, the query will have 'suboriginremotelsn',
> > 'subenabled', 'subfailover' twice.
> 
> Thank you. Fixed and rebased.

Attached new version with significant changes:

  - fixed several issues (including some improper merges in the last
rebase)
  - refactored to share code between postgres_fdw_connection() and
connect_pg_server()
  - added docs in postgres_fdw
  - added tests in core
  - bumped postgres_fdw version to 1.3

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Document new catalog columns, missed in commit 8185bb5347.
- 90630ec42939 19 (unreleased) landed
Refactor to remove ForeignServerName().
- 11f8018ee678 19 (unreleased) landed
GetSubscription(): use per-object memory context.
- f16f5d608ca6 19 (unreleased) landed
Fix dependency on FDW's connection function.
- 4a0b46b6e1e4 19 (unreleased) landed
ALTER SUBSCRIPTION ... SERVER test.
- 1c5bf1185af0 19 (unreleased) landed
Fix pg_dump for CREATE FOREIGN DATA WRAPPER ... CONNECTION.
- b71bf3b84570 19 (unreleased) landed
Clean up postgres_fdw/t/010_subscription.pl.
- f4af7849b3db 19 (unreleased) landed
CREATE SUBSCRIPTION ... SERVER.
- 8185bb534763 19 (unreleased) landed
Allow upgrades to preserve the full subscription's state.
- 9a17be1e244a 17.0 cited