Horton

Re: Should we add a compiler warning for large stack frames?

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Date: 2024-04-12T12:29:29Z
Lists: pgsql-hackers 
On 2024-04-11 Th 16:17, Andres Freund wrote:
> 128k is probably not going to be an issue in practice. However, it also seems
> not great from a performance POV to use this much stack in a function that's
> called fairly often.  I'd allocate the buffer in verify_backup_checksums() and
> reuse it across all to-be-checked files.
>
>

Yes, I agree. I'll make that happen in the next day or two.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

  1. Don't allocate large buffer on the stack in pg_verifybackup