Horton

Re: Backporting BackgroundPsql

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, Melanie Plageman <melanieplageman@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Mikael Kjellström <mikael.kjellstrom@gmail.com>, Robert Haas <robertmhaas@gmail.com>
Date: 2024-06-27T16:35:05Z
Lists: pgsql-hackers 
On 26/06/2024 14:54, Robert Haas wrote:
> On Wed, Jun 26, 2024 at 3:34 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> I haven't looked closely at the new PgFFI stuff but +1 on that in
>> general, and it makes sense to backport that once it lands on master. In
>> the meanwhile, I think we should backport BackgroundPsql as it is, to
>> make it possible to backport tests using it right now, even if it is
>> short-lived.
> 
> +1. The fact that PgFFI may be coming isn't a reason to not back-patch
> this. The risk of back-patching testing infrastructure is also very
> low as compared with code; in fact, there's a lot of risk from NOT
> back-patching popular testing infrastructure.

Ok, I pushed commits to backport BackgroundPsql down to v12. I used 
"option 2", i.e. I changed background_psql() to return the new 
BackgroundPsql object.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Fix missing installation/uninstallation rules for BackgroundPsql.pm

  2. Backport BackgroundPsql perl test module

  3. Add missing uninstallation rule for BackgroundPsql.pm

  4. Fix missing installation rules for BackgroundPsql.pm

  5. Skip \password TAP test on old IPC::Run versions

  6. Test SCRAM iteration changes with psql \password

  7. Refactor background psql TAP functions