Horton

Re: backend type in log_line_prefix?

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-03-15T10:32:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add backend type to csvlog and optionally log_line_prefix

  2. Remove am_syslogger global variable

  3. Unify several ways to tracking backend type

  4. Refactor ps_status.c API

  5. Add background worker type

On 2020-03-13 22:24, Peter Eisentraut wrote:
> On 2020-03-10 19:07, Alvaro Herrera wrote:
>> I like these patches; the first two are nice cleanup.
>>
>> My only gripe is that pgstat_get_backend_desc() is not really a pgstat
>> function; I think it should have a different name with a prototype in
>> miscadmin.h (next to the enum's new location, which I would put
>> someplace near the "pmod.h" comment rather than where you put it;
>> perhaps just above the AuxProcType definition), and implementation
>> probably in miscinit.c.
> 
> I have committed the refactoring patches with adjustments along these
> lines.  The patch with the log_line_prefix and csvlog enhancements is
> still under discussion.

I have committed that last one also, after some corrections.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services