Horton

Re: Failure in contrib test _int on loach

Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

View thread View on postgr.es
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>, Teodor Sigaev <teodor@sigaev.ru>
Date: 2019-04-29T13:16:22Z
Lists: pgsql-hackers

Attachments

27.04.2019 22:05, Tom Lane wrote:
> Anastasia Lubennikova <a.lubennikova@postgrespro.ru> writes:
>> So it is possible, but it doesn't require any extra algorithm changes.
>> I didn't manage to generate dataset to reproduce grandparent split.
>> Though, I do agree that it's worth checking out. Do you have any ideas?
> Ping?  This thread has gone cold, but the bug is still there, and
> IMV it's a beta blocker.

Hi,

Thank you for the reminder.
In a nutshell, this fix is ready for committer.

In previous emails, I have sent two patches with test and bugfix (see 
attached).
After Heikki shared his concerns, I've rechecked the algorithm and 
haven't found any potential error.
So, if other hackers are agreed with my reasoning, the suggested fix is 
sufficient and can be committed.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Detect internal GiST page splits correctly during index build.

  2. Generate less WAL during GiST, GIN and SP-GiST index build.