Re: amcheck: Remove unused IndexCheckableCallback typedef

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-07-04T14:29:35Z
Lists: pgsql-hackers

On 2025/07/04 17:25, Andrey Borodin wrote:
> 
> 
>> On 4 Jul 2025, at 10:50, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>>  From the discussion in [1], it seems this typedef was originally used as
>> a function argument in early versions of the patch. However,
>> the argument was removed in v23, and the typedef was accidentally left behind.
> 
> Yes, your analysis is correct. We could make common checking function and argument was not needed.
> 
>>
>> The attached patch removes this unused typedef to clean up the dead code.
>> Thoughts?
> 
> Looks good to me. Thanks for fixing this!

Thanks for the review! I've pushed the patch.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation




Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. amcheck: Remove unused IndexCheckableCallback typedef.

  2. amcheck: Move common routines into a separate module