Re: Partitioned tables and relfilenode

Maksim Milyutin <m.milyutin@postgrespro.ru>

From: Maksim Milyutin <m.milyutin@postgrespro.ru>

To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2017-03-23T14:27:14Z

Lists: pgsql-hackers

Attachments

exclude_unlinking_storage_for_partitioned_table.patch (text/x-patch) patch

Hi!

I have noticed that there is scheduled unlinking of nonexistent physical 
storage under partitioned table when we execute DROP TABLE statement on 
this partitioned table. Though this action doesn't generate any error 
under typical behavior of postgres because the error of storage's lack 
is caught through if-statement [1] I think it is not safe.

My patch fixes this issue.

1. src/backend/storage/smgr/md.c:1385

-- 
Maksim Milyutin
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Commits

Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.
- 1d5fede4a900 10.0 landed
Don't allocate storage for partitioned tables.
- c94e6942cefe 10.0 landed
Don't scan partitioned tables.
- d3cc37f1d801 10.0 landed
Don't uselessly rewrite, truncate, VACUUM, or ANALYZE partitioned tables.
- 3c3bb99330aa 10.0 landed