Horton
Menu

Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, "Joshua D. Drake" <jd@commandprompt.com>, Thomas Munro <thomas.munro@enterprisedb.com>, David Steele <david@pgmasters.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Craig Ringer <craig@2ndquadrant.com>
Date: 2018-08-24T19:42:33Z
Lists: pgsql-hackers 

On 08/24/2018 02:38 PM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2018-08-24 14:09:09 -0400, Andrew Dunstan wrote:
>>> However, we only support VS2017 down to 9.6 and Vs2015 down to 9.5. Perhaps
>>> we should consider backpatching support for those down to 9.3.
>> Hm, I have no strong objections to that.   I don't think it's strictly
>> necessary, given 2013 is supported across the board, but for the non MSVC
>> world, we do fix compiler issues in older branches.  There's not that
>> much code for the newer versions afaict?
> +1 for taking a look at how big a patch it would be.  But I kind of
> thought we'd intentionally rejected back-patching some of those changes
> to begin with, so I'm not sure the end decision will change.

The VS2017 patch applies cleanly to 9.5, so that seems easy. The VS2015 
patch from 9.5 needs a very small amount of adjustment by the look of it 
for 9.3 and 9.4, after which I hope the VS2017 patch would again apply 
cleanly.

I'll try to put this together.

The trouble with not back patching support to all live branches as new 
versions come in is that it acts as a significant discouragement to 
buildfarm owners to use the latest Visual Studio versions. I've never 
argued stringly on this point before, but I think i'm goiung to ber 
inclined to in future.

Meanwhile, I will turn bowerbird back on but just for >= 9.6 for now.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove test for VA_ARGS, implied by C99.

  2. Introduce minimal C99 usage to verify compiler support.

  3. Require C99 (and thus MSCV 2013 upwards).

  4. Require a C99-compliant snprintf(), and remove related workarounds.

  5. Try to enable C99 in configure, but do not rely on it (yet).

  6. Make snprintf.c follow the C99 standard for snprintf's result value.

  7. Clean up assorted misuses of snprintf()'s result value.