Re: [PATCH]Feature improvement for MERGE tab completion

Shinya Kato <shinya11.kato@oss.nttdata.com>

From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: bt22kawamotok <bt22kawamotok@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-09-13T04:56:44Z
Lists: pgsql-hackers
On 2022-09-12 18:20, bt22kawamotok wrote:
> Other than this correction, the parts that can be put together in OR
> were corrected in fix_tab_completion_merge_v4.patch.

When I tried to apply this patch, I got the following warning, please 
fix it.
Other than that, I think everything is fine.

$ git apply fix_tab_completion_merge_v4.patch
fix_tab_completion_merge_v4.patch:38: trailing whitespace.
         else if (TailMatches("USING", MatchAny, "ON", MatchAny) ||
fix_tab_completion_merge_v4.patch:39: indent with spaces.
                  TailMatches("USING", MatchAny, "AS", MatchAny, "ON", 
MatchAny) ||
fix_tab_completion_merge_v4.patch:40: indent with spaces.
                  TailMatches("USING", MatchAny, MatchAny, "ON", 
MatchAny))
fix_tab_completion_merge_v4.patch:53: trailing whitespace.
         else if (TailMatches("WHEN", "MATCHED") ||
warning: 4 lines add whitespace errors.

-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Commits

  1. Push lpp variable closer to usage in heapgetpage()

  2. psql: Improve tab-completion for MERGE.