Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-04-30T12:57:39Z
Lists: pgsql-hackers 
On 2023-04-28 Fr 05:25, Alvaro Herrera wrote:
> On 2023-Feb-05, Andrew Dunstan wrote:
>
>> So here's a diff made from running perltidy v20221112 with the additional
>> setting --valign-exclusion-list=", = => || && if unless"
> I ran this experimentally with perltidy 20230309, and compared that with
> the --novalign behavior (not to propose the latter -- just to be aware
> of what else is vertical alignment doing.)


Thanks for looking.


>
> Based on the differences between both, I think we'll definitely want to
> include =~ and |= in this list, and I think we should discuss whether to
> also include "or" (for "do_stuff or die()" type of constructs) and "qw"
> (mainly used in 'use Foo qw(one two)' import lists).  All these have
> effects (albeit smaller than the list you gave) on our existing code.


I'm good with all of these I think


>
>
> If you change from an exclusion list to --novalign then you lose
> alignment of trailing # comments, which personally I find a loss, even
> though they're still a multi-line effect.  Another change would be that
> it ditches alignment of "{" but that only changes msvc/Install.pm, so I
> think we shouldn't worry; and then there's this one:
>
> -use PostgreSQL::Test::Utils          ();
> +use PostgreSQL::Test::Utils ();
>   use PostgreSQL::Test::BackgroundPsql ();
>
> which I think we could just change to qw() if we cared enough (but I bet
> we don't).


Yeah, me too.


>
>
> All in all, I think sticking to
> --valign-exclusion-list=", = => =~ |= || && if or qw unless"
> is a good deal.
>

wfm


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.