Horton

Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)

Bryan Green <dbryan.green@gmail.com>

View thread
From: Bryan Green <dbryan.green@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>, Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-30T09:40:06Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add backtrace support for Windows using DbgHelp API

On 10/30/2025 3:37 AM, Álvaro Herrera wrote:
> On 2025-Oct-30, Jakub Wartak wrote:
> 
>> Hi Bryan, cfbot is red. I'm was fan of having those tests for this
>> (bring complexity and we didn't have tests for Linux backtrace
>> anyway), but now MINGW win32 is failing on those tests where the
>> feature is not present:
> 
> I hate to say this after the code is written, but I think we should not
> put any tests in the first step.  I predict that these are going to be
> enormously brittle and that we'll waste a lot of time making them
> stable.  I think we should commit the Windows support for backtraces
> first, then consider whether we actually want TAP tests for the overall
> feature.  We've gone several years with glibc backtrace support without
> any tests -- why do we think the Windows implementation thereof _must_
> necessarily have them?
> 
It will not bother me to remove them.  It was my first effort at writing 
TAP tests, so it was a nice learning experience.