Re: Allow pg_archivecleanup to remove backup history files

torikoshia <torikoshia@oss.nttdata.com>

From: torikoshia <torikoshia@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2023-05-09T13:32:59Z
Lists: pgsql-hackers

Attachments

Horiguchi-san, Michael-san

Thanks for your comments and information!

Attached a patch with documentation and regression tests.


On 2023-04-26 06:39, Michael Paquier wrote:
> On Tue, Apr 25, 2023 at 05:29:48PM +0900, Kyotaro Horiguchi wrote:
>> I thought that we have decided not to do that, but I coundn't find any
>> discussion about it in the ML archive.  Anyway, I think it is great
>> that we have that option.
> 
> No objections from here to make that optional.  It's been argued for a
> couple of times that leaving the archive history files is good for
> debugging, but I can also get why one would one to clean up all the
> files older than a WAL retention policy.  Even if these are just few
> bytes, it can be noisy for the eye to see a large accumulation of
> history files mixed with the WAL segments.
> --
> Michael

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Commits

  1. pg_archivecleanup: Add --clean-backup-history

  2. pg_archivecleanup: Refactor loop doing old segment removals

  3. Introduce long options in pg_archivecleanup