Re: perl checking

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-05-19T01:05:41Z
Lists: pgsql-hackers
On 5/18/18 14:02, Andrew Dunstan wrote:
> These two small patches allow us to run "perl -cw" cleanly on all our 
> perl code.

It's not clear to me what that really means.  My understanding is that
perl "warnings" are primarily a run-time instrument, unlike 'use strict'
and perl -c.  I have been playing with a private branch that adds 'use
warnings' next to 'use strict' across the perl scripts, and there are a
number of warnings that pop up at run time.  The fact that you get even
more warnings at compile time makes me wonder.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Avoid use of unportable hex constant in convutils.pm