Horton

Re: [PATCH] Add native windows on arm64 support

Niyas Sait <niyas.sait@linaro.org>

View thread View on postgr.es
From: Niyas Sait <niyas.sait@linaro.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Ian Lawrence Barwick <barwick@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-12-02T09:37:43Z
Lists: pgsql-hackers 
On 02/12/2022 05:02, Michael Paquier wrote:
> Thanks for the updated version.  I have been looking at it closely and
> it looks like it should be able to do the job (no arm64 machine for
> Windows here, sigh).
> 
> I have one tiny comment about this part:
> 
> -       USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK => undef,
> +       USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK => 1,
> 
> Shouldn't we only enable this flag when we are under aarch64?
> Similarly, I don't think that it is a good idea to switch on
> USE_SSE42_CRC32C_WITH_RUNTIME_CHECK all the time.  We should only set
> it when building under x86 and x86_64.
> 

Ok, I will fix ARM64 specific one in the next revision.

-- 
Niyas

Commits

  1. MSVC: Support building for AArch64.

  2. Remove "#ifdef WIN32" guards from src/port/win32*.c

  3. Adjust XML test case to avoid unstable behavior.

  4. Enable RandomizedBaseAddress (ASLR) on Windows with MSVC builds