Re: a very significant fraction of the buildfarm is now pink
Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>,
Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
Andrei Lepikhov <lepihov@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-24T12:27:02Z
Lists: pgsql-hackers
Hi, Regarding the patch push, I am not a committer, but perhaps my perspective might be interesting. When I noticed late on Friday evening that the tests had failed, I was quite anxious about the situation, thinking I would need to fix it right away. However, Robert committed the fix before that. In general, when someone commits in any project, I believe the scale of the commit should be taken into account. In the case of postgres, if the commit changes code in critical areas like the planner, WAL, or some API, or involves large code changes, it’s important to be prepared to fix any issues that may arise. However, when changes are more minor—such as documentation, renaming something, or small refactors—committing late on a Friday may be less of a concern. In other words, the larger the changes or the more vulnerable the areas of the code, the more one should be prepared for potential issues. But how to determine this boundary in postgres, I am not sure. I am confident that you will have a much better sense and experience of how to handle it. -- Best regards, Ilia Evdokimov, Tantor Labs LLC.
Commits
-
EXPLAIN: Always use two fractional digits for row counts.
- 95dbd827f2ed 18.0 landed
-
Adjust EXPLAIN test case to filter out "Actual Rows" values.
- 44cbba9a7f51 18.0 cited
-
Allow EXPLAIN to indicate fractional rows.
- ddb17e387aa2 18.0 landed
-
Fix pgbench performance issue induced by commit af35fe501.
- fb056564ec5b 18.0 cited