Horton
Menu

Re: Document default values for pgoutput options + fix missing initialization for "origin"

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Amit Kapila <amit.kapila16@gmail.com>, Euler Taveira <euler@eulerto.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-05-21T07:29:36Z
Lists: pgsql-hackers 

On 2025/05/20 13:09, Amit Kapila wrote:
>> +       Option to enable streaming of in-progress transactions. Valid values are
>> +       <literal>off</literal> (the default), <literal>on</literal> and
>> +       <literal>parallel</literal>. The setting <literal>parallel</literal>
>> +       enables sending extra information with some messages to be used for
>> +       parallelization. Minimum protocol version 2 is required to turn it
>> +       <literal>on</literal>.  Minimum protocol version 4 is required for the
>> +       <literal>parallel</literal> value.
>>
> 
> One point to note about this is that we change the default value for
> the streaming option to parallel for a subscription in the commit
> 1bf1140be8. But pgoutput still considers the default value to be off.
> I thought about this, but not sure if there is any clear value in
> changing the default of pgoutput. Would you have any thoughts on the
> same?

Using "off" as the pgoutput's default seems better to me,
since it works regardless of protocol version.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pgoutput: Initialize missing default for "origin" parameter.

  2. doc: Document default values for pgoutput options in protocol.sgml.

  3. doc: Fix confusing description of streaming option in START_REPLICATION.

  4. Change the default value of the streaming option to 'parallel'.

  5. Allow users to skip logical replication of data having origin.