perl checking

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-05-18T18:02:39Z
Lists: pgsql-hackers

Attachments

These two small patches allow us to run "perl -cw" cleanly on all our 
perl code.


One patch silences a warning from convutils.pl about the unportability 
of the literal 0x100000000. We've run for many years without this giving 
us a problem, so I think we can turn the warning off pretty safely.


The other patch provides a dummy library that emulates just enough of 
the Win32 perl infrastructure to allow us to run these checks. That 
means that Unix-based developers who might want to make changes in the 
msvc code can actually run a check against their code without having to 
put it on a Windows machine. The invocation goes like this (to check 
Mkvcbuild.pl for example):


    PERL5LIB=src/tools/msvc/dummylib perl -cw src/tools/Mkvcbuild.pm


This also allows us to check src/tools/win32tzlist.pl.


In due course I'll submit a script to automate this syntax checking.


cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Avoid use of unportable hex constant in convutils.pm