Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Michael Paquier <michael@paquier.xyz>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jacob Champion <jchampion@timescale.com>, Tobias Bussmann <t.bussmann@gmx.net>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org

Date: 2023-07-19T23:16:45Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Skip .DS_Store files in server side utils
- d3fdfdcd1c7f 13.15 landed
- c1fc502f595b 17.0 landed
- aeee173d2292 14.12 landed
- 76bb6dd2e56c 12.19 landed
- 29f00523808a 15.7 landed
- 103235888d9e 16.3 landed

Attachments

v6-0001-Skip-.DS_Store-files-in-server-side-utils.patch (application/octet-stream) patch v6-0001

> On 17 Jul 2023, at 10:29, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Fri, Jul 14, 2023 at 03:07:08PM +0200, Daniel Gustafsson wrote:
>> Judging by the thread there seems to be concensus on skipping .DS_Store files
>> in all branches, with a few +1's for skipping all hidden files in HEAD.  I'll
>> prepare a patch for the former and we can pick up the discussion on the latter
>> ones that's done.
> 
> Yes, I am also getting that this is the consensus reached here.

Attached is a version that just skips .DS_Store files as per the discussion
here.  I opted for not testing this on macOS since I don't want to create
invalid .DS_Store files where they potentially can be seen by the Finder
causing unwanted side effects.

--
Daniel Gustafsson