Horton

Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

View thread View on postgr.es
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Luis Carril <luis.carril@swarm64.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, PG Bug reporting form <noreply@postgresql.org>, Michael Paquier <michael.paquier@gmail.com>
Date: 2018-12-19T09:12:12Z
Lists: pgsql-bugs 
(2018/12/19 17:34), Michael Paquier wrote:
> On Wed, Dec 19, 2018 at 04:49:19PM +0900, Etsuro Fujita wrote:
>> BTW I noticed that this error occurs not only for foreign tables but for
>> views with INSTEAD OF INSERT triggers.  Here is an example on HEAD:
>>
>> To fix this I think we would also need the same treatment for the view case.
>
> Yes, this means an extra relkind check for views.

I think so too.  I think it might be better to add regression tests for 
the view case as well, though.

> Would you like to
> update the patch yourself?

I'd be happy if you worked on that.

Best regards,
Etsuro Fujita

Commits

  1. Disable WAL-skipping optimization for COPY on views

  2. Disable WAL-skipping optimization for COPY on views and foreign tables