Horton

Re: Different compression methods for FPI

x4mmm@yandex-team.ru

View thread View on postgr.es
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>
Date: 2021-06-20T18:15:08Z
Lists: pgsql-hackers 

> 17 июня 2021 г., в 11:44, Michael Paquier <michael@paquier.xyz> написал(а):
> 
> I have worked more on that today and finished with two patches

I have some small questions.

1.
+			report_invalid_record(record, "image at %X/%X compressed with %s not supported, block %d",
+								  (uint32) (record->ReadRecPtr >> 32),
+								  (uint32) record->ReadRecPtr,
+								  "lz4",
+								  block_id);
Can we point out to user that the problem is in the build? Also, maybe %s can be inlined to lz4 in this case.

2.
> const char *method = "???";
Maybe we can use something like "unknown" for unknown compression methods? Or is it too long string for waldump output?

3. Can we exclude lz4 from config if it's not supported by the build?

Thanks!

Best regards, Andrey Borodin.

Commits

  1. Add more error context to RestoreBlockImage() and consume it

  2. Add support for LZ4 with compression of full-page writes in WAL

  3. Extended statistics on expressions

  4. Be clear about whether a recovery pause has taken effect.

  5. Add GUC to enable compression of full page images stored in WAL.