Horton

Re: A few new options for vacuumdb

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2019-01-21T22:09:09Z
Lists: pgsql-hackers

Attachments

Here's a new patch set that should address the feedback in this
thread.  The changes in this version include:

 - 0001 is a small fix to the 'vacuumdb --disable-page-skipping'
   documentation.  My suggestion is to keep it short and simple like
   --full, --freeze, --skip-locked, --verbose, and --analyze.  The
   DISABLE_PAGE_SKIPPING option is well-described in the VACUUM
   documentation, and IMO it is reasonably obvious that such vacuumdb
   options correspond to the VACUUM options.
 - v3-0002 is essentially v2-0001 and v2-0004 combined.  I've also
   added a comment explaining the importance of fully qualifying the
   catalog query used to discover tables to process.
 - 0003 includes additional documentation changes explaining the main
   uses of --min-xid-age and --min-mxid-age and linking to the
   existing wraparound documentation.

As discussed, I've left out the patch for --min-relation-size for now.

Nathan

Commits

  1. Add --min-xid-age and --min-mxid-age options to vacuumdb

  2. Do not filter by relkind in vacuumdb's catalog query if --table is used

  3. Use catalog query to discover tables to process in vacuumdb

  4. Add TAP tests for vacuumdb with column lists

  5. Make vacuumdb test regex more modular for its query output

  6. Adjust documentation for vacuumdb --disable-page-skipping

  7. Add --disable-page-skipping and --skip-locked to vacuumdb