Re: Let's get rid of serial_schedule

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-05-11T19:11:32Z
Lists: pgsql-hackers
> On 11 May 2021, at 20:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> We've several times discussed doing $SUBJECT by replacing the
> makefile's use of serial_schedule with calling parallel_schedule
> with --max-connections=1.  This'd remove the need to maintain
> two lists of regression test scripts.
> 
> I got annoyed again just now about how people seem unable to
> keep the two lists in the same order, so here is a patch to
> get rid of serial_schedule in that way.

Very much +1 on this approach.

> +	# for backwards compatibility, interpret "serial" as parallel tests

This comment may seem odd without reading the commit message.  Perhaps it can
be reworded to "..as parallel tests running with a single worker" or something
along those lines?

--
Daniel Gustafsson		https://vmware.com/




Commits

  1. Fix vcregress.pl's ancient misspelling of --max-connections.

  2. Get rid of the separate serial_schedule list of tests.