Horton

Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled.

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

View thread View on postgr.es
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-08-02T11:12:15Z
Lists: pgsql-hackers 
(2018/08/02 2:44), Robert Haas wrote:
> Tom, Ashutosh, and I all seem to agree that we shouldn't try to
> re-jigger things at create-plan time.  I think that a 3-1 consensus
> against your proposal is sufficient to say we shouldn't go that way.

Agreed.

> Now, here you've got a new approach which avoids that, which I have
> not yet reviewed.  I'll try to spend some time on it this afternoon,
> but really, I think it's too late for this.  This bug was reported in
> February, and we're supposed to be pushing 11 final out the door in
> not much more than a month.  Proposing a new approach in August is not
> good.

Agreed.

> Can't we just do what Ashutosh proposed for now and revisit
> this for v12?

I think that may be possible.

Best regards,
Etsuro Fujita

Commits

  1. Adjust EXPLAIN's output for disabled nodes

  2. Disable support for partitionwise joins in problematic cases.

  3. Rewrite the code that applies scan/join targets to paths.