Re: Minor comment update in execPartition.c
Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-25T03:08:47Z
Lists: pgsql-hackers
(2018/04/25 11:05), Alvaro Herrera wrote: > Amit Langote wrote: > >>> I think we should remove the words "if not already done" from that >>> comment because 1) that function is called if the partition wasn't >>> already initialized and 2) that function assumes that. Attached is a >>> small patch for removing the words. >> >> Thanks, sounds fine. I think those words remain from earlier versions of >> the patch committed as edd44738bc8 [1], where there used to be a fast-path >> return if the ResultRelInfo was already non-NULL for the passed in index. > > Makes sense -- pushed, thanks both. Thanks for committing, Alvaro! Thanks for reviewing, Amit! Best regards, Etsuro Fujita
Commits
-
Update ExecInitPartitionInfo comment
- bd4aad32395c 11.0 landed