Horton

Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

View thread View on postgr.es
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2017-11-27T05:38:12Z
Lists: pgsql-hackers 
(2017/11/27 7:56), Tom Lane wrote:
> Etsuro Fujita<fujita.etsuro@lab.ntt.co.jp>  writes:
>> [ fix-rewrite-tlist-v4.patch ]
>
> I started reviewing this patch.

Great!

> I did not much like the fact that it
> effectively moved rewriteTargetListUD to a different file and renamed it.
> That seems like unnecessary code churn, plus it breaks the analogy with
> rewriteTargetListIU, plus it will make back-patching harder (since that
> code isn't exactly the same in back branches).  I see little reason why
> we can't leave it where it is and just make it non-static.  It's not like
> there's no other parts of the rewriter that the planner calls.

Agreed.

Best regards,
Etsuro Fujita

Commits

  1. Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.