Horton

Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

View thread View on postgr.es
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-05T12:44:37Z
Lists: pgsql-hackers

Attachments

Hi Arthur,

(2018/03/03 18:51), Arthur Zakirov wrote:
> On Wed, Feb 28, 2018 at 05:22:42PM +0900, Etsuro Fujita wrote:
>> I rebased the patch over HEAD and revised comments/docs a little bit. Please
>> find attached a new version of the patch.
>
> I've reviewed the patch.
>
> The code is good, clear and it is pretty small. There are documentation
> fixes and additional regression tests.
>
> Unfortunately the patch is outdated and it needs rebasing. Outdated
> files are regression tests files.
>
> After rebasing regression tests they pass.

I rebased the patch over HEAD.  Please find attached an updated patch.

Thank you for the review!

Best regards,
Etsuro Fujita

Commits

  1. Fix WITH CHECK OPTION on views referencing postgres_fdw tables.

  2. Allow insert and update tuple routing and COPY for foreign tables.

  3. When WCOs are present, disable direct foreign table modification.