Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>, Rushabh Lathia <rushabh.lathia@gmail.com>, Michael Paquier <michael.paquier@gmail.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Date: 2018-03-05T03:21:29Z
Lists: pgsql-hackers
(2018/03/03 5:01), Robert Haas wrote:
> On Fri, Mar 2, 2018 at 1:20 PM, Robert Haas<robertmhaas@gmail.com>  wrote:
>> On Fri, Mar 2, 2018 at 5:35 AM, Etsuro Fujita
>> <fujita.etsuro@lab.ntt.co.jp>  wrote:
>>> Agreed.  Better safe than sorry, so I disabled autovacuum for all the tables
>>> created in the postgres_fdw regression test, except the ones with no data
>>> modification created in the sections "test handling of collations" and "test
>>> IMPORT FOREIGN SCHEMA".  I'm attaching a patch for that.
>>
>> I have committed this patch.  Whee!

Thank you for taking the time on this!

> And that seems to have made things worse.  The failures on rhinocerous
> look related:
>
> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=rhinoceros&br=HEAD

Totally outdated stats used in query planning causes the failures? 
ANALYZE right before the plan-changing queries would fix the failures?

> And so does this failure on chub:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chub&dt=2018-03-02%2016%3A10%3A02

The Git log shows that this was done before the commit.

Best regards,
Etsuro Fujita


Commits

  1. Temporarily instrument postgres_fdw test to look for statistics changes.

  2. postgres_fdw: Fourth attempt to stabilize regression tests.

  3. postgres_fdw: Third attempt to stabilize regression tests.

  4. postgres_fdw: Attmempt to stabilize regression tests.

  5. postgres_fdw: Push down UPDATE/DELETE joins to remote servers.