Re: non-bulk inserts and tuple routing
Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-01-30T09:22:50Z
Lists: pgsql-hackers
(2018/01/25 18:52), Amit Langote wrote: > On 2018/01/25 18:30, Etsuro Fujita wrote: >> The patches apply cleanly and compile successfully, but make check fails >> in an assert-enabled build. > > Hmm, I can't seem to reproduce the failure with v4 patches I posted > earlier today. > Can you please post the errors you're seeing? A quick debug showed that the failure was due to a segmentation fault caused by this change to ExecSetupPartitionTupleRouting (in patch v4-0003-During-tuple-routing-initialize-per-partition-obj): - bool is_update = false; + bool is_update; I modified that patch to initialize the is_update to false as before. With the modified version, make check passed successfully. I'll review the patch in more detail! Best regards, Etsuro Fujita
Commits
-
Fix parent node of WCO expressions in partitioned tables.
- d06aba240d24 11.0 landed
-
Update PartitionTupleRouting struct comment
- 364de2566514 11.0 landed
-
Be lazier about partition tuple routing.
- edd44738bc88 11.0 landed