Horton

useless LIMIT_OPTION_DEFAULT

Zhang Mingli <zmlpostgres@gmail.com>

View thread View on postgr.es
From: Zhang Mingli <zmlpostgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-14T01:17:33Z
Lists: pgsql-hackers

Attachments

Hi, all

By reading the codes, I found that we process limit option as LIMIT_OPTION_WITH_TIES when using WITH TIES
and all others are LIMIT_OPTION_COUNT by  commit 357889eb17bb9c9336c4f324ceb1651da616fe57.
And check actual limit node in limit_needed().
There is no need to maintain a useless default limit enum.
I remove it and have an install check to verify.

Are there any considerations behind this?
Shall we remove it for clear as it’s not actually the default option.


Zhang Mingli
www.hashdata.xyz

Commits

  1. Remove useless LIMIT_OPTION_DEFAULT value from LimitOption

  2. Support FETCH FIRST WITH TIES