Horton

Re: CLUSTER command progress monitor

Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>

View thread View on postgr.es
From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@enterprisedb.com>, sawada.mshk@gmail.com
Date: 2017-09-07T06:46:03Z
Lists: pgsql-hackers 
On 2017/09/06 16:11, Michael Paquier wrote:
> On Wed, Sep 6, 2017 at 3:58 PM, Tatsuro Yamada
> <yamada.tatsuro@lab.ntt.co.jp> wrote:
>> I revised the patch like this:
>
> You should avoid top-posting.

I see.

>> I didn't change the name of view (pg_stat_progress_cluster) because I'm not
>> sure
>> whether the new name (pg_stat_progress_reorg) is suitable or not.
>
> Here are some ideas: rewrite (incorrect for ALTER TABLE), organize
> (somewhat fine), order, operate (too general?), bundle, reform,
> assemble.

Thanks for sharing your ideas.
I searched the words like a "reform table", "reassemble table" and "reorganize table"
on google. I realized "reorganaize table" is good choice than others
because many DBMS uses this keyword. Therefore, I'll change the name to it like this:

before
   pg_stat_progress_cluster

after
   pg_stat_progress_reorg (I abbreviate reorganize to reorg.)

Does anyone have any suggestions?
I'll revise the patch.

Regards,
Tatsuro Yamada

Commits

  1. Fix progress reporting of CLUSTER / VACUUM FULL

  2. Fix thinko when ending progress report for a backend

  3. Report progress of REINDEX operations

  4. Add progress reporting for CLUSTER and VACUUM FULL.

  5. Un-hide most cascaded-drop details in regression test results.

  6. Fix memory leak in printtup.c.

  7. Remove unused macro