Horton

Re: CLUSTER command progress monitor

Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>

View thread View on postgr.es
From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-09-04T11:17:38Z
Lists: pgsql-hackers 
On 2017/09/04 15:38, Michael Paquier wrote:
> On Thu, Aug 31, 2017 at 11:12 AM, Tatsuro Yamada
> <yamada.tatsuro@lab.ntt.co.jp> wrote:
>> Then I have questions.
>>
>>    * Should we have separate views for them?  Or should both be covered by the
>>      same view with some indication of which command (CLUSTER or VACUUM FULL)
>>      is actually running?
>
> Using the same view for both, and tell that this is rather VACUUM or
> CLUSTER in the view, would be better IMO. Coming up with a name more
> generic than pg_stat_progress_cluster may be better though if this
> speaks with VACUUM FULL as well, user-facing documentation does not
> say that VACUUM FULL is actually CLUSTER.

Thanks for sharing your thoughts.
Agreed.
I'll add new column like a "command" to tell whether running CLUSTER or VACUUM.
And how about this new view name?
  - pg_stat_progress_reorg
Is it more general name than previous name if it covers both commands?


>> I'll add this patch to CF2017-09.
>> Any comments or suggestion are welcome.
>
> Nice to see that you are taking the time to implement patches for
> upstream, Yamada-san!

Same here. :)
I'd like to contribute creating feature that is for DBA and users.
Progress monitoring feature is important from my DBA experiences.
I'm happy if you lend your hand.

Thanks,
Tatsuro Yamada

Commits

  1. Fix progress reporting of CLUSTER / VACUUM FULL

  2. Fix thinko when ending progress report for a backend

  3. Report progress of REINDEX operations

  4. Add progress reporting for CLUSTER and VACUUM FULL.

  5. Un-hide most cascaded-drop details in regression test results.

  6. Fix memory leak in printtup.c.

  7. Remove unused macro