Horton

Re: please update ps display for recovery checkpoint

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>, Thomas Munro <thomas.munro@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-12-11T18:54:42Z
Lists: pgsql-hackers

Attachments

On 12/10/20, 7:54 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> However, I think that it would be better to have all those four code
> paths controlled by a single routine, where we pass down the
> checkpoint flags and fill in the ps string directly depending on what
> the caller wants to do.  This way, we will avoid any inconsistent
> updates if this stuff gets extended in the future, and there will be
> all the information at hand to extend the logic.  So I have simplified
> your patch as per the attached.  Thoughts?

This approach seems reasonable to me.  I've attached my take on it.

Nathan

Commits

  1. Provide recovery_init_sync_method=syncfs.

  2. Add some checkpoint/restartpoint status to ps display