Horton

Re: Probable documentation errors or improvements

Yaroslav <ladayaroslav@yandex.ru>

View thread View on postgr.es
From: Щекин Ярослав <ladayaroslav@yandex.ru>
To: Justin Pryzby <pryzby@telsasoft.com>, Heikki Linnakangas <hlinnaka@iki.fi>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, David G Johnston <david.g.johnston@gmail.com>, Teodor Sigaev <teodor@sigaev.ru>, Oleg Bartunov <obartunov@postgrespro.ru>, Dmitry Ivanov <d.ivanov@postgrespro.ru>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Arthur Zakirov <a.zakirov@postgrespro.ru>
Date: 2020-11-20T17:51:12Z
Lists: pgsql-hackers

Attachments

  Thank you for preparing the patches, and Heikki Linnakangas for pushing those!


  

    Yaroslav, could you prepare a patch for your remaining suggestions ?

    I suggest to include just the handful of items which are most important (most

    wrong/ambiguous/confusing).
  


  
    Let me write this again: I'm not a native speaker, so not sure those are actually incorrect, and can't offer non-trivial suggestions.
  
  
     
  
  
    Anyway, I've tried to remove the already fixed things (also by other patches mentioned in the thread) from my initial list, and attach it.
  
  
     
  
  
    Also, I've looked over the pushed patches, and spotted these:
  
  
     
  
  
    -- https://www.postgresql.org/docs/current/catalog-pg-authid.html
  
  
     
  
  
    Table 51.8. pg_authid Columns
  
  
    -- Some rows in the description have point at the end, some don't (seemingly at random).
  
  
     
  
  
    The applied patch fixed only one of those cases... also seemingly at random. Would be nice if someone read the whole table and made a decision about how it should be. If (just guessing here) the rule is "there should be no point if it's just one sentence", then "Role bypasses every row level security policy, see Section 5.8 for more information." is still wrong.
  
  
     
  
  
    Then, while ";" after "END" were added in doc/src/sgml/plpgsql.sgml, but in doc/src/sgml/func.sgml they still were not.
  
  
     
  
  
    Finally, while the patches fix a lot of whitespace in function arguments, the original complaint about div() and mod() is still not fixed.
  


   


  -- 


  WBR, Yaroslav Schekin.

Commits

  1. doc: Remove more notes about compatibilities with past versions

  2. Misc documentation fixes.

  3. Fix TRUNCATE doc: ALTER SEQUENCE RESTART is now transactional.

  4. Fix output of tsquery example in docs.

  5. Fix doc for full text search distance operator.

  6. Phrase full text search.