Horton

Re: speeding up planning with partitions

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <david.rowley@2ndquadrant.com>
Cc: Imai Yoshikazu <yoshikazu_i443@live.jp>, "jesper.pedersen@redhat.com" <jesper.pedersen@redhat.com>, "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>, Amit Langote <amitlangote09@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-28T04:57:13Z
Lists: pgsql-hackers 
On 2019/03/27 23:57, Tom Lane wrote:
> David Rowley <david.rowley@2ndquadrant.com> writes:
>> On Wed, 27 Mar 2019 at 18:39, Amit Langote
>> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>> On 2019/03/27 14:26, David Rowley wrote:
>>>> Perhaps the way to make this work, at least in the long term is to do
>>>> in the planner what we did in the executor in d73f4c74dd34.
> 
>>> Maybe you meant 9ddef36278a9?
> 
>> Probably.
> 
> Yeah, there's something to be said for having plancat.c open each table
> *and store the Relation pointer in the RelOptInfo*, and then close that
> again at the end of planning rather than immediately.  If we can't avoid
> these retail table_opens without a great deal of pain, that's the
> direction I'd tend to go in.  However it would add some overhead, in
> the form of a need to traverse the RelOptInfo array an additional time.

Just to be sure, do you mean we should do that now or later (David said
"in the long term")?

Thanks,
Amit

Commits

  1. Clean up handling of constraint_exclusion and enable_partition_pruning.

  2. Add test case exercising formerly-unreached code in inheritance_planner.

  3. Speed up planning when partitions can be pruned at plan time.

  4. Avoid crash in partitionwise join planning under GEQO.

  5. Avoid passing query tlist around separately from root->processed_tlist.

  6. Build "other rels" of appendrel baserels in a separate step.

  7. Get rid of duplicate child RTE for a partitioned table.

  8. Rearrange make_partitionedrel_pruneinfo to avoid work when we can't prune.

  9. Don't copy PartitionBoundInfo in set_relation_partition_info.

  10. Move building of child base quals out into a new function

  11. Reorganize planner code moved in b60c39759908

  12. Move inheritance expansion code into its own file

  13. Fix inherited UPDATE/DELETE with UNION ALL subqueries.

  14. Rearrange planner to save the whole PlannerInfo (subroot) for a subquery.