Re: Enable data checksums by default

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-11-13T08:31:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid BufferGetLSNAtomic() calls during nbtree scans.
- e6eed40e4441 18.0 cited
doc PG 18 relnotes: Add incompatibility note about checksums now default
- 48814415d5aa 18.0 landed
Fix pg_upgrade's cross-version tests when old < 18
- 38c18710b37a 18.0 landed
initdb: Change default to using data checksums.
- 04bec894a04c 18.0 landed
Allow TAP tests to force checksums off when calling init()
- e7d0cf42b1ac 18.0 landed
initdb: Add new option "--no-data-checksums"
- 983a588e0b86 18.0 landed
Tweak docs to reduce possible impact of data checksums
- efd72a3d422b 18.0 landed

On 07.11.24 19:38, Alvaro Herrera wrote:
> I have just noticed that since this patch was committed as 04bec894a04c,
> pg_upgrade's "make check" action is unusable when given the
> "olddump/oldinstall" options.  We now need to inject '-k' to the initdb
> line for old servers, and we don't, so all upgrade tests fail.  I think
> this patch should be enough to fix it.

Yes, this fix looks correct.  (Or the other way around: Disable 
checksums on the new node.)

Is this not being covered by the build farm?  Are the upgrade tests 
there not using this?