Re: Stack-based tracking of per-node WAL/buffer usage

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>

To: Lukas Fittl <lukas@fittl.com>, Andres Freund <andres@anarazel.de>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Zsolt Parragi <zsolt.parragi@percona.com>, Tomas Vondra <tomas@vondra.me>, Peter Smith <smithpb2250@gmail.com>

Date: 2026-04-05T18:22:25Z

Lists: pgsql-hackers

On 05/04/2026 15:31, Lukas Fittl wrote:
> Heikki, your further review is very welcome, if you have the time.
> It'd also be great if you could review the README.instrument (now in
> v13/0008) to see if that makes sense to you.

I don't have very substantial comments to make, an haven't had a chance 
to review the latest patch, but I did read your replies. I think I 
understand the stack vs. tree model now and why it is the way it is, but 
I still find it pretty confusing and I don't know what to about it.

- Heikki

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

instrumentation: Allocate query level instrumentation in ExecutorStart
- 2c16deee2f7d 19 (unreleased) landed
instrumentation: Move ExecProcNodeInstr to allow inlining
- 544000288ec8 19 (unreleased) landed
instrumentation: Separate per-node logic from other uses
- 5a79e78501f4 19 (unreleased) landed
instrumentation: Separate trigger logic from other uses
- 7d9b74df53e9 19 (unreleased) landed
instrumentation: Rename INSTR_TIME_LT macro to INSTR_TIME_GT
- 3218825271bd 19 (unreleased) landed
instrumentation: Keep time fields as instrtime, convert in callers
- e5a5e0a90750 19 (unreleased) landed