Horton

Thread

Commits

  1. Sync function prototype with its actual definition.

  1. Minor code improvement to postgresGetForeignPlan

    Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> — 2017-04-07T04:12:31Z

    Hi,

The declaration of postgresGetForeignPlan uses baserel, but
the actual definition uses foreignrel. It would be better to sync.

Please find attached a patch.

Tatsuro Yamada
NTT Open Source Software Center

  2. Re: Minor code improvement to postgresGetForeignPlan

    Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> — 2017-09-01T09:30:38Z

    On 2017/04/07 13:12, Tatsuro Yamada wrote:> The declaration of  
postgresGetForeignPlan uses baserel, but
> the actual definition uses foreignrel. It would be better to sync.

Agreed.

> Please find attached a patch.

The patch looks good to me, so I'll mark this as Ready for Committer.

(I'm not sure we should do the same thing to the function declaration in  
other places such as fdwapi.h and the documentation for consistency, but  
if so, I'd vote for leaving that for another patch.)

Best regards,
Etsuro Fujita

  3. Re: Minor code improvement to postgresGetForeignPlan

    Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> — 2017-09-04T06:45:17Z

    Hi Fujita-san,

> The patch looks good to me, so I'll mark this as Ready for Committer.

Thanks for reviewing my patch.


> (I'm not sure we should do the same thing to the function declaration in other places such as fdwapi.h and the documentation for consistency, but if so, I'd vote for leaving that for another patch.)

+1

Regards,
Tatsuro Yamada

  4. Re: Minor code improvement to postgresGetForeignPlan

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-09-06T21:52:56Z

    Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> writes:
> The declaration of postgresGetForeignPlan uses baserel, but
> the actual definition uses foreignrel. It would be better to sync.

Pushed, thanks.

			regards, tom lane

  5. Re: Minor code improvement to postgresGetForeignPlan

    Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> — 2017-09-07T00:22:40Z

    On 2017/09/07 6:52, Tom Lane wrote:
> Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> writes:
>> The declaration of postgresGetForeignPlan uses baserel, but
>> the actual definition uses foreignrel. It would be better to sync.
>
> Pushed, thanks.
>
> 			regards, tom lane

Thanks!

Regards,
Tatsuro Yamada