Re: Assignment of valid collation for SET operations on queries with UNKNOWN types.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Rahila Syed <rahilasyed90@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2016-11-17T15:29:35Z
Lists: pgsql-hackers
Rahila Syed <rahilasyed90@gmail.com> writes: > CASE 2: > postgres=# create view v as select 'abc' a; > 2016-11-16 15:28:48 IST WARNING: column "a" has type "unknown" > 2016-11-16 15:28:48 IST DETAIL: Proceeding with relation creation anyway. > WARNING: column "a" has type "unknown" > DETAIL: Proceeding with relation creation anyway. > CREATE VIEW We really ought to make that a hard error. And ideally fix things so that the type of the view column will be resolved as text, so that you don't hit this condition in the first place; but there is no good that comes out of allowing a view to be created like this. > Attached WIP patch does that. Kindly let me know your opinion. This is a seriously ugly kluge that's attacking the symptom not the problem. Or really, a symptom not the problem. There are lots of other symptoms, for instance regression=# select * from v order by 1; ERROR: failed to find conversion function from unknown to text regards, tom lane
Commits
-
Remove vestigial resolveUnknown arguments from transformSortClause etc.
- aebeb4790c75 10.0 landed
-
Make UNKNOWN into an actual pseudo-type.
- d8d32d9a56a3 10.0 landed
-
Change unknown-type literals to type text in SELECT and RETURNING lists.
- 1e7c4bb00497 10.0 landed