small cleanup patches for collation code

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: pgsql-hackers@postgresql.org

Date: 2026-04-17T19:30:37Z

Lists: pgsql-hackers

Attachments

v1-0001-style-define-parameterless-functions-as-foo-void.patch (text/x-patch) patch v1-0001
v1-0002-Fix-callers-of-unicode_strtitle-using-srclen-1.patch (text/x-patch) patch v1-0002

Two patches attached.

0001 fixes a style issue. Backport because it eliminates a warning in
the 'update-unicode' target.

0002 looks like a bug, but is not a real issue because there are no
callers that pass srclen==-1, aside from a test (which fails to fail).
So it's just cleanup, but it seems worth backporting.

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix callers of unicode_strtitle() using srclen == -1.
- 6044f55a47f5 18.4 landed
- bdcb85b56ac4 19 (unreleased) landed
style: define parameterless functions as foo(void).
- 59919ec7761f 19 (unreleased) landed