Re: Replace current implementations in crypt() and gen_salt() to OpenSSL

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Joe Conway <mail@joeconway.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, "Koshi Shibagaki (Fujitsu)" <shibagaki.koshi@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-04T13:54:17Z
Lists: pgsql-hackers

Attachments

> On 3 Dec 2024, at 22:56, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 3 Dec 2024, at 15:04, Joe Conway <mail@joeconway.com> wrote:
>> 
>> On 12/3/24 08:59, Daniel Gustafsson wrote:
>>>> On 24 Nov 2024, at 14:48, Daniel Gustafsson <daniel@yesql.se> wrote:
>>> Any other opinions or should we proceed with the proposed GUC?
>> 
>> I'm good with it. Did you want to commit or would you rather I do it?
> 
> No worries, I can make it happen.  ssnce there has been no objections since
> this patch was posted I'll get it commmitted shortly.

Looking over this again I realized it's a bit silly to fall back on FIPS_mode()
when EVP_default_properties_is_fips_enabled isn't available since that would
only be OpenSSL versions before 3.0 (and since we don't support 1.0.2 then no
such version can have FIPS).  Sharing back a v3 which is what I think we should
go with.

--
Daniel Gustafsson

Commits

  1. pgcrypto: Make it possible to disable built-in crypto

  2. pgcrypto: Add function to check FIPS mode

  3. citext: Allow tests to pass in OpenSSL FIPS mode

  4. pgcrypto: Remove non-OpenSSL support