Re: Add two missing tests in 035_standby_logical_decoding.pl
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>
Cc: "Yu Shi (Fujitsu)" <shiy.fnst@fujitsu.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-05-04T05:46:04Z
Lists: pgsql-hackers
Hi,
On 5/4/23 6:43 AM, Amit Kapila wrote:
> On Thu, May 4, 2023 at 8:37 AM vignesh C <vignesh21@gmail.com> wrote:
>>
>> Thanks for posting the updated patch, I had run this test in a loop of
>> 100 times to verify that there was no failure because of race
>> conditions. The 100 times execution passed successfully.
>>
>> One suggestion:
>> "wal file" should be changed to "WAL file":
>> +# Request a checkpoint on the standby to trigger the WAL file(s) removal
>> +$node_standby->safe_psql('postgres', 'checkpoint;');
>> +
>> +# Verify that the wal file has not been retained on the standby
>> +my $standby_walfile = $node_standby->data_dir . '/pg_wal/' . $walfile_name;
>>
>
> Thanks for the verification. I have pushed the patch.
>
Thanks!
I've marked the CF entry as Committed and moved the associated PostgreSQL 16 Open Item
to "resolved before 16beta1".
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Commits
-
Fix the race condition in the test case added by commit a6e04b1d20.
- c5b7f67fcc8c 16.0 landed
-
Test that invalidated logical slots doesn't retain WAL.
- a6e04b1d20c2 16.0 landed
-
Add a test to verify that subscription to the standby works.
- 376dc820531b 16.0 landed
-
Reduce the log level in 035_standby_logical_decoding.pl.
- 3034dc56ef4b 16.0 landed