Horton

Re: [PATCH] quiet conversion warning in DatumGetFloat4

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chapman Flack <chap@anastigmatix.net>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-31T05:26:30Z
Lists: pgsql-hackers 
Chapman Flack <chap@anastigmatix.net> writes:
> -	myunion.value = GET_4_BYTES(X);
> +	myunion.value = (int32)GET_4_BYTES(X);

Hm.  I think it would be better to use DatumGetInt32 here.  Arguably,
direct use of GET_4_BYTES and its siblings should only appear in
DatumGetFoo macros.

			regards, tom lane

Commits

  1. Avoid -Wconversion warnings from direct use of GET_n_BYTES macros.